Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Generalized environment variables' table #198

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[DOC] Generalized environment variables' table #198

merged 2 commits into from
Oct 10, 2023

Conversation

rmanaem
Copy link
Collaborator

@rmanaem rmanaem commented Oct 10, 2023 •
edited by alyssadai
Loading

Closes #188

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6474610968

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.786%
Totals Coverage Status
Change from base Build 6408018485: 0.0%
Covered Lines: 467
Relevant Lines: 468
💛 - Coveralls

@alyssadai alyssadai self-requested a review October 10, 2023 17:55
alyssadai
alyssadai approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change for the NB_GRAPH_ROOT_HOST description, otherwise 🧑‍🍳

docs/api_environment_variables.tsv Outdated Show resolved Hide resolved
@rmanaem @alyssadai
Update docs/api_environment_variables.tsv
3c301f5 
Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com>
@rmanaem rmanaem merged commit d63d262 into main Oct 10, 2023
5 checks passed
@rmanaem rmanaem deleted the doc-188 branch October 10, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize environment vars table to Stardog or GraphDB backends
3 participants
@rmanaem @coveralls @alyssadai