Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Remove --no-progress-meter #227

Merged
merged 1 commit into from
Nov 23, 2023
Merged

[FIX] Remove --no-progress-meter #227

merged 1 commit into from
Nov 23, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Nov 23, 2023 •
edited by alyssadai
Loading

Changes proposed in this pull request:

  • replace the --no-progress-meter argument with -s -S which has the same effect but works on curl < 7.67.0

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6973817264

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.732%
Totals Coverage Status
Change from base Build 6882033445: 0.0%
Covered Lines: 745
Relevant Lines: 747
💛 - Coveralls

@alyssadai alyssadai self-requested a review November 23, 2023 20:24
alyssadai
alyssadai approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs
Copy link
Contributor Author

surchs commented Nov 23, 2023

🤞

@surchs surchs merged commit e58bec4 into main Nov 23, 2023
5 checks passed
@surchs surchs deleted the issue213 branch November 23, 2023 20:30
@alyssadai alyssadai mentioned this pull request Jan 8, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add_data_to_graph.sh errors out for older versions of curl
3 participants
@surchs @coveralls @alyssadai