-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook for modularity #36
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might not need to have two copies of the Modularity notebook itself. Is there a reason for the modularity folder as well?
OK then I can remove it |
Besides that, I still cannot figure out why there are two duplicate plots |
It is probably because you have the visualization function returning the figure as well as plotting it with |
Thanks, that works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'd suggest doing a grammar and spelling check in some of the subtitle blocks, saw some minor edits needed. I'd recommend to either end every markdown block with a period or end none with one, for consistency.
For the code-blocks that output the values in mod and the nan for Ciona, I'd recommend either getting rid of those or putting a code-block before them explaining why you are outputting these values.
Other than this, it looks good to me! Interesting work
Fix #16
Still couldn't figure out why the modularity of ciona is nan