Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook for modularity #36

Merged
merged 12 commits into from
May 7, 2021
Merged

Add notebook for modularity #36

merged 12 commits into from
May 7, 2021

Conversation

Jingyan230
Copy link
Collaborator

@Jingyan230 Jingyan230 commented May 5, 2021

Fix #16
Still couldn't figure out why the modularity of ciona is nan

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

modularity/Modularity.ipynb Outdated Show resolved Hide resolved
modularity/Modularity.ipynb Outdated Show resolved Hide resolved
modularity/Modularity.ipynb Outdated Show resolved Hide resolved
@Jingyan230 Jingyan230 changed the title Add notebook for calculate modularity Add notebook for modularity May 6, 2021
@CaseyWeiner CaseyWeiner self-requested a review May 7, 2021 04:05
Copy link
Collaborator

@CaseyWeiner CaseyWeiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might not need to have two copies of the Modularity notebook itself. Is there a reason for the modularity folder as well?

@Jingyan230
Copy link
Collaborator Author

OK then I can remove it

@Jingyan230
Copy link
Collaborator Author

Besides that, I still cannot figure out why there are two duplicate plots

@CaseyWeiner
Copy link
Collaborator

Besides that, I still cannot figure out why there are two duplicate plots

It is probably because you have the visualization function returning the figure as well as plotting it with return fig. Have you tried commenting that out?

@Jingyan230
Copy link
Collaborator Author

Besides that, I still cannot figure out why there are two duplicate plots

It is probably because you have the visualization function returning the figure as well as plotting it with return fig. Have you tried commenting that out?

Thanks, that works

Copy link
Collaborator

@CaseyWeiner CaseyWeiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'd suggest doing a grammar and spelling check in some of the subtitle blocks, saw some minor edits needed. I'd recommend to either end every markdown block with a period or end none with one, for consistency.

For the code-blocks that output the values in mod and the nan for Ciona, I'd recommend either getting rid of those or putting a code-block before them explaining why you are outputting these values.

Other than this, it looks good to me! Interesting work

docs/_toc.yml Outdated Show resolved Hide resolved
docs/_toc.yml Outdated Show resolved Hide resolved
docs/Modularity.ipynb Outdated Show resolved Hide resolved
docs/Modularity.ipynb Outdated Show resolved Hide resolved
docs/Modularity.ipynb Outdated Show resolved Hide resolved
docs/Modularity.ipynb Outdated Show resolved Hide resolved
docs/Modularity.ipynb Outdated Show resolved Hide resolved
docs/Modularity.ipynb Outdated Show resolved Hide resolved
@CaseyWeiner CaseyWeiner merged commit 096ab56 into main May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run modularity
3 participants