Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a distance and speed property to accessor #147

Closed
sfmig opened this issue Mar 18, 2024 · 8 comments · Fixed by #280
Closed

Consider adding a distance and speed property to accessor #147

sfmig opened this issue Mar 18, 2024 · 8 comments · Fixed by #280
Labels
enhancement New optional feature

Comments

@sfmig
Copy link
Contributor

sfmig commented Mar 18, 2024

From the kinematics tutorial PR review:

We could add a "distance" property in our accessor to access directly the distance travelled, e.g:

distance_travelled = ds.move.distance

Similarly with speed.

@sfmig sfmig added the enhancement New optional feature label Mar 18, 2024
@sfmig sfmig changed the title Consider adding a distance property to accessor Consider adding a distance and speed property to accessor Mar 18, 2024
@sfmig sfmig mentioned this issue Mar 18, 2024
7 tasks
@sfmig
Copy link
Contributor Author

sfmig commented Mar 21, 2024

Make a method instead of a property.
Nomenclature: ds.get_cumulative_distance() ?

@niksirbi
Copy link
Member

Maybe ds.cumulative_displacement(from=0, to=100)? Because we will literally calculate it as cumsum of the displacement.

@niksirbi
Copy link
Member

See exhaustive discussion in #162

@sfmig
Copy link
Contributor Author

sfmig commented May 13, 2024

@niksirbi @lochhh seems like we can close this now?

@lochhh
Copy link
Collaborator

lochhh commented May 13, 2024

or edit this to add more convenience methods to the accessor, e.g. compute_speed, compute_distance_travelled as suggested here?

@niksirbi
Copy link
Member

Yeah, i'd keep it open, because we may consider adding those convenience methods.

@niksirbi
Copy link
Member

Consider calling distance "path length"

@niksirbi
Copy link
Member

niksirbi commented Oct 8, 2024

We've decided to refer to "distance travelled" as path_length, to avoid confusion with pairwise distances (see #277).

While implementing the compute_path_length() function, I encountered a dilemma on how to handle missing values, see discussion on zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature
Projects
Development

Successfully merging a pull request may close this issue.

3 participants