Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request checks failling because of failing lint of existing code in main #31

Closed
matjobst opened this issue Jul 19, 2023 · 2 comments
Assignees

Comments

@matjobst
Copy link
Collaborator

Currently, pull requests such as #30 are failing, because of Lint problems with existing code in main:
Error: example/nengo/nir-lorentz.py:182:89: E501 Line too long (94 > 88 characters)
Error: example/nengo/nir-test.py:67:89: E501 Line too long (94 > 88 characters)
Error: example/sinabs/import_to_sinabs.py:2:20: F401 torch.nn imported but unused
Error: example/sinabs/import_to_sinabs.py:3:25: F401 sinabs.layers imported but unused

I suggest locking the main branch from direct commits to enforce the use of pull requests along with the checks.

@sheiksadique
Copy link
Collaborator

This issue should be fixed now. But I agree about marking the main branch as protected.

@biphasic
Copy link
Member

main branch is locked now, can only take up new commits through PRs. @sheiksadique you might want to check pre-commit as noted here https://github.com/neuromorphs/NIRTorch#for-developers
Will add a comment in the NIR readme too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants