Add optional description to predictor upload #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
- Coverage 82.31% 82.29% -0.03%
==========================================
Files 57 57
Lines 2177 2180 +3
==========================================
+ Hits 1792 1794 +2
- Misses 385 386 +1
Continue to review full report at Codecov.
|
|
Closes #624 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now pass an object/dictionary as
descriptionswhen youPOSTto /api/predictors/collection`.This lets you set the description for each of the columns in your events. In the future, we can expand this to add more meta-data but for now I think it's all we need.