Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json string for collection description #634

Merged
merged 2 commits into from Aug 4, 2019
Merged

Conversation

adelavega
Copy link
Collaborator

Merged #632 too soon. requests can pass dictionary, so i'm going to try dumping as string, and reading that in on the server side.

@adelavega
Copy link
Collaborator Author

Great, looks like that works, will merge when tests pass.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@82fcdd2). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #634   +/-   ##
=========================================
  Coverage          ?   82.22%           
=========================================
  Files             ?       57           
  Lines             ?     2183           
  Branches          ?        0           
=========================================
  Hits              ?     1795           
  Misses            ?      388           
  Partials          ?        0
Impacted Files Coverage Δ
neuroscout/resources/predictor.py 88.46% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fcdd2...5696cd8. Read the comment docs.

@adelavega adelavega merged commit 00b677e into master Aug 4, 2019
@adelavega adelavega deleted the fix/coll_desc branch October 2, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants