Skip to content

Commit

Permalink
Fixed the issue of process not exiting when window is closed (#12)
Browse files Browse the repository at this point in the history
* Fix close process on exit

* Removed $ from commands (#8)

* added CHANGELOG.md file (#9)

* Update CHANGELOG.md

* Removed misleading full-stop (#14)

* Update README.md

* Extract title from parsed webpage fetched through URL (#10)

* Removed $ from commands

* Set default title as hostname

* Update readme.md

* Update readme.md

* Update readme.md

* Improved Extraction of title

* parsed webpage and used regex to get title from tiitle tag

* removed unnecessary async

* improved indentation

* Update index.js

Co-authored-by: Shalitha Suranga <shalithasuranga@gmail.com>

* fixed invalid link (#16)

* Fix close process on exit

* Reverted auto formatting

Co-authored-by: Ayman <76606666+Ayman161803@users.noreply.github.com>
Co-authored-by: JASKEERAT SINGH <jaskeerat10000@gmail.com>
Co-authored-by: Shalitha Suranga <shalithasuranga@gmail.com>
Co-authored-by: Wu Tingfeng <wu.tingfeng@u.nus.edu>
  • Loading branch information
5 people committed May 2, 2022
1 parent ea5e1a8 commit 6d0c9d5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = {
modules.config.update('applicationId', appId);
modules.config.update('modes.window.title', title);
modules.config.update('modes.window.enableInspector', false);
modules.config.update('modes.window.exitProcessOnClose', true);

// Bundle it
await modules.bundler.bundleApp(true);
Expand Down Expand Up @@ -44,4 +45,4 @@ function getTitle(url) {
reject('');
});
})
}
}

0 comments on commit 6d0c9d5

Please sign in to comment.