Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue of process not exiting when window is closed #12

Merged
merged 11 commits into from
May 2, 2022
Merged

Fixed the issue of process not exiting when window is closed #12

merged 11 commits into from
May 2, 2022

Conversation

NethmiRodrigo
Copy link
Contributor

Fixes #5

shalithasuranga
shalithasuranga approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this PR. All good, but could you please use the original formatting (I guess it's a four-space indentation)? We are going to create a in-depth document for JavaScript/C++ code styling, but please update it manually this time ;)

@NethmiRodrigo
Copy link
Contributor Author

Thanks for sending this PR. All good, but could you please use the original formatting (I guess it's a four-space indentation)? We are going to create a in-depth document for JavaScript/C++ code styling, but please update it manually this time ;)

Will do! Sorry that was prettier doing that😅

shalithasuranga and others added 2 commits April 15, 2022 17:01
@shalithasuranga
Update README.md
7ff25c1
@Ayman161803 @shalithasuranga
Extract title from parsed webpage fetched through URL (#10)
f23c31a 
* Removed $ from commands

* Set default title as hostname

* Update readme.md

* Update readme.md

* Update readme.md

* Improved Extraction of title

* parsed webpage and used regex to get title from tiitle tag

* removed unnecessary async

* improved indentation

* Update index.js

Co-authored-by: Shalitha Suranga <shalithasuranga@gmail.com>
@shalithasuranga
Copy link
Member

Hey.. seems like now we have some Git conflicts. If you could update the code style and fix conflicting files, we can merge this PR 🎉 Thanks :)

@NethmiRodrigo
Copy link
Contributor Author

Hey.. seems like now we have some Git conflicts. If you could update the code style and fix conflicting files, we can merge this PR 🎉 Thanks :)

Hi! Sorry about the delay. Fixed the conflicts and the indentation issue. Hope its alright now :)

@shalithasuranga
Copy link
Member

Hey.. thanks for the update. could you please double-check and match the existing code style? I think you can checkout to the original version and add only the specific line without auto-formatting ;)

@NethmiRodrigo
Copy link
Contributor Author

Hey.. thanks for the update. could you please double-check and match the existing code style? I think you can checkout to the original version and add only the specific line without auto-formatting ;)

Sorry about that. I took it now from the original version and added only the specific line. Will turn prettier off next time😅

shalithasuranga
shalithasuranga approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.. Thanks 🎉

@shalithasuranga shalithasuranga merged commit 6d0c9d5 into neutralinojs:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalithasuranga shalithasuranga shalithasuranga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix process exit issue
5 participants
@NethmiRodrigo @shalithasuranga @Ayman161803 @0xJaskeerat @elliotwutingfeng