Extract title from parsed webpage fetched through URL #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Ayman161803 Thank you very much for sending this pull request. Seems like the issue that I created is not very clear. I meant "parsing from webpage" from the "from URL" phrase. I've updated the issue: #6 Will you be able to update this pull request accordingly? Thanks 🎉 |
|
Hey @shalithasuranga! I have updated this PR according to changes in issue title. Methodology UsedParse the webpage and retrieve HTML title tag using regex manipulations. Sample inputs and outputs
|
Ayman161803
changed the title
|
Hey @Ayman161803 Thanks. I have updated a few things from the GitHub editor and will double-check those updates locally 🎉 |
shalithasuranga
added a commit
that referenced
this pull request
May 2, 2022
* Fix close process on exit * Removed $ from commands (#8) * added CHANGELOG.md file (#9) * Update CHANGELOG.md * Removed misleading full-stop (#14) * Update README.md * Extract title from parsed webpage fetched through URL (#10) * Removed $ from commands * Set default title as hostname * Update readme.md * Update readme.md * Update readme.md * Improved Extraction of title * parsed webpage and used regex to get title from tiitle tag * removed unnecessary async * improved indentation * Update index.js Co-authored-by: Shalitha Suranga <shalithasuranga@gmail.com> * fixed invalid link (#16) * Fix close process on exit * Reverted auto formatting Co-authored-by: Ayman <76606666+Ayman161803@users.noreply.github.com> Co-authored-by: JASKEERAT SINGH <jaskeerat10000@gmail.com> Co-authored-by: Shalitha Suranga <shalithasuranga@gmail.com> Co-authored-by: Wu Tingfeng <wu.tingfeng@u.nus.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Here a sample working of URL.hostname functionality.
Example results of the logic written
https://github.com/gajagdh
Resulting Name: github
https://www.nitk.ac.in/ahajhsh
Resulting Name: nitk