-
Notifications
You must be signed in to change notification settings - Fork 214
Tests fail because of CRLF-LF #1628
Comments
May be (I am not sure) it will fix it in my personal environment. But it will not save other developers from this issue. The good practice is to keep everything always in LF. But I have no idea where CRLF are generated from. What is also interesting that the half of the generated file is LF and the another half is CRLF Another option: do you think we can apply local Git configs and commit them to the repository? |
Yeah the SO link has suggestions for how to set up a |
Turned out the issue comes from absolutely another side facebook/jscodeshift#195 . Recast (the nested dependency) automatically chooses OS end of line for code generation. I tried Have no idea how to make it work. The only options are to redesign the test or disable testing on commit as they block. PRs will be still tested on CI |
Bug
Here is the output from the CLI
CRLF - is code generated from
migrate
LF - is code generated from
packages\migrate\test\fixtures\.neutrinorc.js.txt
The full output from the CLI
I believe this happens due to Git auto conversion of line endings (Git client feature) during cloning and commit. But I may be wrong. Any ideas how to fix this?
The text was updated successfully, but these errors were encountered: