Minor logging fixes in xrdp_iso.c #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt335672
reviewed
Feb 15, 2022
libxrdp/xrdp_iso.c
Outdated
| @@ -428,7 +428,7 @@ xrdp_iso_send_cc(struct xrdp_iso *self) | |||
| out_uint16_le(s, 8); /* length (must be 8) */ | |||
| out_uint32_le(s, self->selectedProtocol); /* selectedProtocol */ | |||
| LOG_DEVEL(LOG_LEVEL_TRACE, "Adding structure [MS-RDPBCGR] RDP_NEG_RSP " | |||
| "flags 0, length 8, selectedProtocol 0x%8.8x", | |||
| "flags 0x01, length 8, selectedProtocol 0x%8.8x", | |||
There was a problem hiding this comment.
Wouldn't it be better to use EXTENDED_CLIENT_DATA_SUPPORTED here as that's what's in the code (e.g.):-
"flags 0x%02x, length 8, selectedProtocol 0x%8.8x",
EXTENDED_DATA_SUPPORTED,
self->selectedProtocol);
Nexarian
force-pushed
the
fix-minor-logging-bugs
branch
from
8d2f681
to
f69860c
Compare
Two logging errors found while working in these files.
Nexarian
force-pushed
the
fix-minor-logging-bugs
branch
from
f69860c
to
d23f732
Compare
|
Thanks @Nexarian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two logging errors found while working in these files.