Increase back-stop timeouts for some tests #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Debian build farm has a number of older and slower machines which need to run the xrdp test suite. On these platforms, we occasionally get timeouts where machine load is high. This results in duplicate issues being raised. It is not obvious that the issues are duplicates, which wastes time all round. This commit splits up some test cases into multiple cases and adds larger timeouts for those cases that are CPU-intensive.
This was referenced Jan 4, 2024
|
@elboulangero - apologies for completely dropping this. Does this look OK to you? |
|
@matt335672 Thanks for spending the time on this!
I guess so, honestly I don't remember much about this now. In any case, I keep an eye on the package in Debian, so if tests keep timing out, or fail for any other reason, I'll re-open a ticket. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2213 #2899
The Debian build farm has a number of older and slower machines which need to run the xrdp test suite.
On these platforms, we occasionally get timeouts where machine load is high. This results in duplicate issues being raised. It is not obvious that the issues are duplicates, which wastes time all round.
This commit splits up some test cases into multiple cases and adds larger timeouts for those cases that are CPU-intensive.