Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFX: Fix disconnect on resize of busy windows #2962

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

matt335672
Copy link
Member

When a resize is underway on a busy X server, it is possible for a queued EGFX cmd (order #62) to be processed after the decoder has been deleted. This causes a client disconnect with no useful error message.

When a resize is underway on a busy X server, it is possible for a
queued EGFX cmd (order neutrinolabs#62) to be processed after the decoder has been
deleted. This causes a client disconnect with no useful error message.
@matt335672 matt335672 merged commit b79a769 into neutrinolabs:devel Feb 23, 2024
13 checks passed
@matt335672 matt335672 deleted the fix_egfx_disconnect branch February 23, 2024 15:35
@matt335672
Copy link
Member Author

@metalefty - can you cherry-pick this one into #2957 please?

@metalefty
Copy link
Member

Sure, the user might have encountered this issue during the acceptance test. I have not yet determined that the problem they encountered is the same as this problem because I couldn't reproduce the issue on my side but the symptom sounds very similar to this.

@Nexarian
Copy link
Contributor

I'm glad you've learned to use GLXGears to test resizing/monitor changes. Because it's such a simple app, it "spams" frames and is very good at finding timing problems.

My other stress test I do is resize while playing a YouTube video (pick your favorite, I usually do music videos such as Epic Rap Battles of History), and if the video (after a few glitchy frames) recovers it's good. However, if it breaks, usually you resize into a black-screen-of-death

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants