Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sidebars on react pages #1957

Closed
wants to merge 33 commits into from
Closed

Implement sidebars on react pages #1957

wants to merge 33 commits into from

Commits on Aug 18, 2020

  1. initial commit: got sidebar to appear

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    0dfa261 View commit details
    Browse the repository at this point in the history

  2. add rough css for react

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    834f667 View commit details
    Browse the repository at this point in the history

  3. add svg for "carrot" indicator

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    9bcb203 View commit details
    Browse the repository at this point in the history

  4. cleaned up construct_react code

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    7b6c2a2 View commit details
    Browse the repository at this point in the history

  5. move updated sidebar to XKit.interface.react.sidebar and revert old one

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    1cc9ee5 View commit details
    Browse the repository at this point in the history

  6. fix sidebar selector for /blog/ page 

    /blog/myblogname has nested aside elements, and we only want the parent one

Co-Authored-By: invalidCards <invalidcards@users.noreply.github.com>
    @marcustyphoon @invalidCards
    marcustyphoon and invalidCards committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    e62ce1a View commit details
    Browse the repository at this point in the history

  7. place sidebar below navigation on "channel" pages

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    0883ecf View commit details
    Browse the repository at this point in the history

  8. cleaned up css

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    9a56a97 View commit details
    Browse the repository at this point in the history

  9. removed legacy fallback code from sidebar.react

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    981c8c0 View commit details
    Browse the repository at this point in the history

  10. behavior fixes 

    only load css if a sidebar is needed
destroy() removes css
added await to fix nothing loading (again)

css moved in next commit to clean up history
    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    c0ae88c View commit details
    Browse the repository at this point in the history

  11. moved css variable 

    split from previous commit for readability
    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ee64114 View commit details
    Browse the repository at this point in the history

  12. add sticky sidebar

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    64ee3a5 View commit details
    Browse the repository at this point in the history

  13. fix the race condition with a MutationObserver

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    c561b4c View commit details
    Browse the repository at this point in the history

  14. version bump

    @marcustyphoon
    marcustyphoon committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    6b7a45d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Merge remote-tracking branch 'upstream/master' into update-interface-… 

    …dot-sidebar
    @marcustyphoon
    marcustyphoon committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1614a85 View commit details
    Browse the repository at this point in the history

  2. version bump again

    @marcustyphoon
    marcustyphoon committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    40953cd View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2020

  1. fixes for legacy sidebars showing up and async-init-fires-multiple-times

    @marcustyphoon
    marcustyphoon committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    356b329 View commit details
    Browse the repository at this point in the history

  2. oops. better fix for async behavior that doesn't break everything

    @marcustyphoon
    marcustyphoon committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    395bfdb View commit details
    Browse the repository at this point in the history

  3. move sticky version into seperate PR

    @marcustyphoon
    marcustyphoon committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    82a29f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. reduce variable scope

    @marcustyphoon
    marcustyphoon committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    a2da7b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Merge remote-tracking branch 'upstream/master' into update-interface-… 

    …dot-sidebar
    @marcustyphoon
    marcustyphoon committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    5046172 View commit details
    Browse the repository at this point in the history

  2. version bump

    @marcustyphoon
    marcustyphoon committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    32253a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. fix indentation

    @marcustyphoon
    marcustyphoon committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    c544af2 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. version bump 

    sdfkjsdkhfksdhfjksdhfksjdhfks
    @marcustyphoon
    marcustyphoon committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    46a50e0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. empty commit to trigger new CI

    @marcustyphoon
    marcustyphoon committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    8775607 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into update-interface-dot-sidebar

    @marcustyphoon
    marcustyphoon committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    86e4207 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Merge branch 'master' into update-interface-dot-sidebar

    @marcustyphoon
    marcustyphoon committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    8bd9a24 View commit details
    Browse the repository at this point in the history

  2. version bump

    @marcustyphoon
    marcustyphoon committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    b8b548b View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. update css for tumblr color change

    @marcustyphoon
    marcustyphoon committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    7664cb3 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Merge remote-tracking branch 'upstream/master' into update-interface-… 

    …dot-sidebar
    @marcustyphoon
    marcustyphoon committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    ef8ad72 View commit details
    Browse the repository at this point in the history

  2. version bump

    @marcustyphoon
    marcustyphoon committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    39a4224 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Merge branch 'master' into update-interface-dot-sidebar

    @marcustyphoon
    marcustyphoon committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    cb11ebd View commit details
    Browse the repository at this point in the history

  2. version bump

    @marcustyphoon
    marcustyphoon committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    eef8acb View commit details
    Browse the repository at this point in the history