Implement sidebars on react pages #1957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
added a commit
to marcustyphoon/XKit
that referenced
this pull request
Aug 12, 2020
8 tasks
marcustyphoon
force-pushed
the
update-interface-dot-sidebar
branch
from
06e34bd
to
5edce30
Compare
marcustyphoon
added a commit
to marcustyphoon/XKit
that referenced
this pull request
Aug 14, 2020
marcustyphoon
commented
Aug 16, 2020
marcustyphoon
force-pushed
the
update-interface-dot-sidebar
branch
from
8877a41
to
af2f98d
Compare
/blog/myblogname has nested aside elements, and we only want the parent one Co-Authored-By: invalidCards <invalidcards@users.noreply.github.com>
only load css if a sidebar is needed destroy() removes css added await to fix nothing loading (again) css moved in next commit to clean up history
split from previous commit for readability
marcustyphoon
force-pushed
the
update-interface-dot-sidebar
branch
from
4dad847
to
6b7a45d
Compare
This was referenced Aug 18, 2020
hobinjk
reviewed
Sep 18, 2020
| * @param {Object[]} [section.items] - Array of objects containing button data | ||
| * @param {String} section.items[].id - Button element ID | ||
| * @param {String} section.items[].text - Visible button text | ||
| * @param {Number/String} [section.items[].count] - Text to be displayed as a counter on the button |
There was a problem hiding this comment.
Another nitpick that doesn't require changing: Number|String is more commonly used. Technically in a type annotation like this it would be number|string since Number and String refer to the boxed versions of the primitive number and string types.
There was a problem hiding this comment.
Yeah, all of the JSDoc—actually, most of the green code here—was copy-paste :D That did look odd though.
sdfkjsdkhfksdhfjksdhfksjdhfks
|
This would (presumably?) need to be rewritten to take the vertical nav layout into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds XKit.interface.react.sidebar functions that work on the new dashboard as identically as possible to XKit.interface.sidebar. It can be tested with this gist, #1966, #1967, and/or #1968.
This code currently places the XKit sidebar items below the main navigation area of
tumblr.com/blog/my_blog_name, and above all other native Tumblr sidebar items, including "recommended blogs," "radar," and "sponsored."The new
addfunction is asynchronous and must beawaited before adding button handlers in extensions.The added functions work on both react and non-react pages.removedIt also includes anremovedXKit.interface.react.sidebar.add_stickyoptionOn react pages, this currently places the xkit sidebar items above all other native Tumblr sidebar items.resolved