Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_lna_gain uses Request::SetVgaGain by mistake #14

Closed
nitroxis opened this issue Jul 11, 2021 · 4 comments · Fixed by #15
Closed

set_lna_gain uses Request::SetVgaGain by mistake #14

nitroxis opened this issue Jul 11, 2021 · 4 comments · Fixed by #15

Comments

@nitroxis
Copy link

nitroxis commented Jul 11, 2021

I believe there's a typo here:

let buf: [u8; 1] = self.read_control(Request::SetVgaGain, gain & !0x07, 0)?;

This should probably be Request::SetLnaGain, no?

@newAM
Copy link
Owner

newAM commented Jul 11, 2021

Yikes, yup, you are correct.

@newAM newAM closed this as completed in #15 Jul 11, 2021
@newAM
Copy link
Owner

newAM commented Jul 11, 2021

Fixed in v0.2.2.

Sorry for the bug 😨

@nitroxis
Copy link
Author

Thanks for the fix! However, setting LNA/VGA gain somehow still has no effect on my HackRF (it does work in other programs). I'm going to investigate further.

@nitroxis
Copy link
Author

I think I found the problem and created a PR: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants