-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Public Catalog] Gatsby 4 + SSR exploration #1821
Comments
The build is currently running into some issues during the "Validating Rendering Engines" step. I believe it may have something to do with the mockGlobals file in our SDK plugin, but I haven't been able to prove that yet. |
The error above was generated when doing a full |
I also tested changing the globalMocks file in the sdk plugin to not override the global object and that did not work. However, removing the plugin completely does allow the site to build. So, the issue appears to be around the |
Re: gatsby v4 ssr. Here's what I did to try and read the new relic api key from node env vars. initially didn't work, but then @nr-kkenney changed the not 100% sure why though. i tested initially using the same env var names and got same error re: no api key. ¯_(ツ)_/¯ Gatsby doc on env vars: https://www.gatsbyjs.com/docs/how-to/local-development/environment-variables/ |
we were able to get our test page to work. we also added the ability to supply an for example: https://developerwebsitecampfiretestv4.gatsbyjs.io/test-ssr/?id=29bd9a4a-1c19-4219-9694-0942f6411ce7 this should mean its possible for us to proceed with our upcoming work. |
This is awesome! I'm curious will this SSR implementation have any impacts to tessen events or analytics we should be aware of? 🤔 |
@jpvajda for now, tessen events fired as expected. depending on implementation down the road (e.g., if a quickstart page URL uses query params to fetch quickstart by |
To prepare for possible integration with the DevEx sort / popularity service we want to test out gatsby 4 with support for SSR to validate this approach is viable.
Assumption
The I/O external site would be able to use this DevEx service to power our sort and popularity functionality instead of rebuilding that ourselves on the external site. This would then allow us to only rely on 1 single service to provide that both the internal and external I/O catalogs.
Acceptance Criteria
This exploration is just for the
DevSite
openInstallation
or thenr1Catalog
nerdgraph endpointsGameday
type issues we need to consider for SLO / SLI metrics.Discuss with DevEx their service used for sort and popularity and plan for that integration which our next epic for I/O Follow up with @jerelmiller for more infoBeing handled in the planning for the next epicGameday considerations
a. sort /popularity service is down
b. gatsby functions are down, which support SSR
c. other
Docs
Some takeaways
GATSBY_
(similar how the new relic browser agent reads the env set inGATSBY_NEWRELIC_ENV
. In thetest-ssr.js
page we used for testing, that env var for the new relic api key is passed along to the SSR function that fetched nerdgraph data. And i did not see any trace of that call in Network requests in the browser.getServerData
SSR function, i didn't see a clear way to see any logs. perhaps we just catch the error and console log the msg?The text was updated successfully, but these errors were encountered: