-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Removing old supportability metrics #669
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 86.66% 86.56% -0.11%
==========================================
Files 131 128 -3
Lines 5039 5090 +51
Branches 638 644 +6
==========================================
+ Hits 4367 4406 +39
- Misses 626 639 +13
+ Partials 46 45 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This will likely need to be a |
Are they charged for metrics though? I thought they don't--only for data stored under their own account. |
Yes, customer are charged for supportability metrics and those do show up in their account. They can go to the metric explorer on any browser entity and see these metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just would like to see page restore come back, but otherwise this looks good
Removing supportability metrics that are no longer needed including polyfill detection, bfcache usage, body and query bytes sent count, and custom attributes size.
Overview
Removing the below supportability metrics:
Updating framework detection for appexp to detect:
Related Issue(s)
https://issues.newrelic.com/browse/NR-94597
https://source.datanerd.us/agents/angler/pull/480
Testing