Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing old supportability metrics #669

Merged
merged 3 commits into from
Aug 31, 2023
Merged

feat: Removing old supportability metrics #669

merged 3 commits into from
Aug 31, 2023

Conversation

patrickhousley
Copy link
Contributor

@patrickhousley patrickhousley commented Aug 29, 2023

Removing supportability metrics that are no longer needed including polyfill detection, bfcache usage, body and query bytes sent count, and custom attributes size.

Overview

Removing the below supportability metrics:

  • Polyfill detection
  • bfcache restores
  • body and query bytes sent for each endpoint
  • js attributes size

Updating framework detection for appexp to detect:

  • nextjs - requires react detection since this is ssr for react
  • nuxtjs - requires vue detection since this is ssr for vue
  • angular universal - requires angular detection since this is ssr for angular
  • svelte - new framework detection for us
  • sveltelit - requires svelte detection since this is ssr for svelte
  • preact - new framework detection for us
  • preact ssr - requires preact detection since this is ssr for preact
  • qwik - new framework detection for us - this one is an interesting html first framework
  • electron - not really a framework but im curious if anyone is using our agent in their electron apps

Related Issue(s)

https://issues.newrelic.com/browse/NR-94597
https://source.datanerd.us/agents/angler/pull/480

Testing

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 27.67 kB / 9.69 kB (gzip) 27.63 kB / 9.68 kB (gzip) -0.11% / -0.12% (gzip)
lite async-chunk 44.51 kB / 14.73 kB (gzip) 43.62 kB / 14.44 kB (gzip) -2.01% / -2% (gzip)
pro loader 44.85 kB / 15.15 kB (gzip) 44.82 kB / 15.14 kB (gzip) -0.07% / -0.09% (gzip)
pro async-chunk 63.97 kB / 20.55 kB (gzip) 63.07 kB / 20.24 kB (gzip) -1.41% / -1.48% (gzip)
spa loader 51.27 kB / 17.1 kB (gzip) 51.24 kB / 17.09 kB (gzip) -0.06% / -0.07% (gzip)
spa async-chunk 78.27 kB / 24.86 kB (gzip) 77.37 kB / 24.54 kB (gzip) -1.15% / -1.26% (gzip)
lite-polyfills loader 98.11 kB / 31.38 kB (gzip) 98.08 kB / 31.36 kB (gzip) -0.03% / -0.04% (gzip)
lite-polyfills async-chunk 54.25 kB / 16.39 kB (gzip) 54.65 kB / 16.42 kB (gzip) 0.75% / 0.2% (gzip)
pro-polyfills loader 117.7 kB / 37.25 kB (gzip) 117.66 kB / 37.24 kB (gzip) -0.03% / -0.03% (gzip)
pro-polyfills async-chunk 94.42 kB / 25.72 kB (gzip) 94.82 kB / 25.76 kB (gzip) 0.43% / 0.15% (gzip)
spa-polyfills loader 125.67 kB / 39.38 kB (gzip) 125.64 kB / 39.37 kB (gzip) -0.02% / -0.03% (gzip)
spa-polyfills async-chunk 109.41 kB / 30.28 kB (gzip) 109.82 kB / 30.32 kB (gzip) 0.37% / 0.14% (gzip)
worker loader 39.79 kB / 13.56 kB (gzip) 39.76 kB / 13.55 kB (gzip) -0.08% / -0.09% (gzip)
worker async-chunk 43.51 kB / 14.81 kB (gzip) 42.63 kB / 14.52 kB (gzip) -2.01% / -2% (gzip)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #669 (cc5924f) into main (efdf5f0) will decrease coverage by 0.11%.
Report is 3 commits behind head on main.
The diff coverage is 79.77%.

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   86.66%   86.56%   -0.11%     
==========================================
  Files         131      128       -3     
  Lines        5039     5090      +51     
  Branches      638      644       +6     
==========================================
+ Hits         4367     4406      +39     
- Misses        626      639      +13     
+ Partials       46       45       -1     
Flag Coverage Δ
integration-tests 86.13% <66.66%> (-0.29%) ⬇️
unit-tests 81.55% <84.74%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/common/config/state/runtime.js 100.00% <ø> (ø)
src/common/harvest/harvest.js 100.00% <ø> (ø)
src/features/metrics/aggregate/index.js 88.52% <75.00%> (-1.62%) ⬇️
.../features/metrics/aggregate/framework-detection.js 81.14% <80.24%> (-12.47%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Static Badge

Last ran on August 31, 2023 09:10:37 CDT
Checking merge of (cc5924f) into main (ec113af)

@metal-messiah
Copy link
Member

This will likely need to be a feat since it affects agent harvests and customer billing (in a good way)

@patrickhousley patrickhousley changed the title chore: cleaning up supportability metrics feat: Removing old supportability metrics Aug 30, 2023
@cwli24
Copy link
Contributor

cwli24 commented Aug 30, 2023

This will likely need to be a feat since it affects agent harvests and customer billing (in a good way)

Are they charged for metrics though? I thought they don't--only for data stored under their own account.

@patrickhousley
Copy link
Contributor Author

This will likely need to be a feat since it affects agent harvests and customer billing (in a good way)

Are they charged for metrics though? I thought they don't--only for data stored under their own account.

Yes, customer are charged for supportability metrics and those do show up in their account. They can go to the metric explorer on any browser entity and see these metrics.

Copy link
Contributor

@cwli24 cwli24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just would like to see page restore come back, but otherwise this looks good

@patrickhousley patrickhousley merged commit c17d344 into main Aug 31, 2023
54 of 58 checks passed
@patrickhousley patrickhousley deleted the sm-cleanup branch August 31, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants