-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(super-agent): Skip core bundle if installed #1604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSSPKrishna
force-pushed
the
pk/skip-superagent
branch
from
May 9, 2024 18:12
f2328ff
to
28c70ba
Compare
Updated the status of the core bundle to NULL from UNSUPPORTED when a super agent is installed, as suggested by @sanderblue. This modification enables easier tracking of installs, particularly in scenarios where a super agent is present. |
Avinash-Sanpala
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sanderblue
approved these changes
May 10, 2024
pranav-new-relic
added a commit
that referenced
this pull request
May 23, 2024
This reverts commit 33768eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request uses the CLI functionality to detect the presence of the Super Agent on the host. If detected, it will install OHI with the Super Agent dependency, skipping the core bundle installation. If core recipes are targeted for installation, they will be unsupported since the Super Agent is already installed. (Associated PR: newrelic/open-install-library#1072)