Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(super-agent): Skip core bundle if installed #1604

Merged
merged 12 commits into from
May 23, 2024
Merged

Conversation

NSSPKrishna
Copy link
Member

This pull request uses the CLI functionality to detect the presence of the Super Agent on the host. If detected, it will install OHI with the Super Agent dependency, skipping the core bundle installation. If core recipes are targeted for installation, they will be unsupported since the Super Agent is already installed. (Associated PR: newrelic/open-install-library#1072)

@NSSPKrishna NSSPKrishna removed the request for review from amolero-nr May 9, 2024 21:20
@NSSPKrishna
Copy link
Member Author

NSSPKrishna commented May 10, 2024

Updated the status of the core bundle to NULL from UNSUPPORTED when a super agent is installed, as suggested by @sanderblue. This modification enables easier tracking of installs, particularly in scenarios where a super agent is present.

Copy link
Contributor

@Avinash-Sanpala Avinash-Sanpala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NSSPKrishna NSSPKrishna merged commit 33768eb into main May 23, 2024
26 of 27 checks passed
@NSSPKrishna NSSPKrishna deleted the pk/skip-superagent branch May 23, 2024 09:48
pranav-new-relic added a commit that referenced this pull request May 23, 2024
pranav-new-relic added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants