Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured maximum stack trace depth is not always honored #683

Closed
JcolemanNR opened this issue Aug 17, 2021 · 0 comments · Fixed by #684
Closed

Configured maximum stack trace depth is not always honored #683

JcolemanNR opened this issue Aug 17, 2021 · 0 comments · Fixed by #684
Assignees
Labels
bug Something isn't working

Comments

@JcolemanNR
Copy link
Contributor

Description
While running the unit tests in debug (not an intended configuration), I noticed a unit test failure with how stack depth is managed. While switching to release configuration does allow the unit tests to pass, there is actually some erroneous logic in how we reduce stack traces.

For example, even the release configuration test asks for a max stack depth of 3, but is satisfied when only 2 are returned despite there being over 40 stack frames that aren't from 'NewRelic' assemblies.

Expected Behavior
If there are enough non 'NewRelic' stack frames, then we should return the requested maximum stack frames.

@JcolemanNR JcolemanNR added the bug Something isn't working label Aug 17, 2021
@JcolemanNR JcolemanNR self-assigned this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant