Address issues found during GitHub action multi arch build #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
commented
Nov 21, 2023
| # in this repository. | ||
| # types: [prereleased, released] | ||
| types: [released] | ||
| types: [prereleased, released] |
There was a problem hiding this comment.
I realized that docker images are pushed on the prerelease event (source)
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
9 tasks
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
etep
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Address issues found during GitHub action multi arch build
This addresses issues found from running the release action. It also relies on the following upstream workflow change (newrelic/k8s-metadata-injection#488) to skip the helm chart version update. This repo's helm chart is managed in the newrelic/helm-charts repo and so the release logic fails when applied to this project.
Relevant Issues: newrelic/helm-charts#1152
Test Plan: The v2.1.8 was successfully built and the prerelease and release builds were successful.