Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think the height on the EmptyState component is always too long #41

Open
danielgolden opened this issue Feb 13, 2020 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@danielgolden
Copy link
Contributor

Description

I think every time I've seen the <EmptyState /> component used outside of the nr1-community docs, it's always extended past the vertical bounds of it's container. I think this is because the height: 100% property isn't taking into account the 16px of margin-top and margin-bottom.

Steps to Reproduce

Go drop <EmptyState /> in a nerdlet and you'll see you either have to scroll to see the bottom of it or it just extends past it's containers height.

Expected Behaviour

I expect that it would sit inside of it's container without the need for scrolling to view it nor would it extend past it's container's height.
NOTE: # ( Tell us what you expected to happen. )

Possible solution

Swap out the height: 100% rule for height: calc(100% - 32px). this removes the extra 32px of height that are coming from the margin top and bottom of .empty-state.
TIP: # ( Include as many relevant details about your environment as possible. )

Additional Context

  • NR1 CLI version used: @datanerd/nr1/1.16.1 darwin-x64 node-v10.16.3
  • Browser name and version: Firefox 72.0.2
  • Operating System and version: MacOS Catalina 10.15.2 (19C57)
@danielgolden danielgolden added bug Something isn't working good first issue Good for newcomers labels Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant