Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker integration should know when it's running in Fargate #49

Closed
orion-fra opened this issue Oct 26, 2020 · 0 comments · Fixed by #50
Closed

Docker integration should know when it's running in Fargate #49

orion-fra opened this issue Oct 26, 2020 · 0 comments · Fixed by #50
Assignees
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@orion-fra
Copy link

orion-fra commented Oct 26, 2020

Description

When running in Fargate the ECS integration is not calling "connect" so all metadata related to the host is lost. Docker integration is also sending metrics without agent entityId.

The result is that the metadata is not decorated and some attributes are lost:

  • awsRegion
  • ecsClusterName
  • ecsClusterArn
  • ecsLaunchType

Expected Behavior

NR Diag results

Steps to Reproduce

See initially filed tickets: https://newrelic.atlassian.net/browse/GTSE-4812
Aso solving: https://newrelic.atlassian.net/secure/RapidBoard.jspa?rapidView=1643&projectKey=GTSE&modal=detail&selectedIssue=GTSE-5145

Your Environment

Additional context

@jlegoff noticed the docker integration is using the same API used by the ECS integration and can detect if it is running inside Fargat

In case the Docker integration is running inside Fargate the integration will send those missing attributes as a metric attribute. For instance, the awsRegion is got from the ARN.

From @paologallinaharbur
We should check that all the metadata is there from the old sample
ODL, NEW

https://github.com/newrelic/nri-ecs/blob/e2b3668bb8b244eda85ce113abac3d2e41251834/internal/metadata/v3/v3.go#L165

https://github.com/newrelic/nri-docker/blob/master/src/docker.go#L47

impersonate - See comments in CoreINT-337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants