Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many problems when building from the scratch #84

Closed
vongosling opened this issue Oct 14, 2020 · 2 comments
Closed

Many problems when building from the scratch #84

vongosling opened this issue Oct 14, 2020 · 2 comments
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@vongosling
Copy link

vongosling commented Oct 14, 2020

  1. === redis === [ validate ]: running gofmt... failed. Incorrect syntax in the following files:
    src/inventory_test.go src/metrics_test.go
    make: *** [Makefile:31: validate-only] Error 1

This is the first problem.

  1. when I remove the validate-only task in the makefile, the following error is :

=== redis === [ validate-deps ]: installing validation dependencies...
go: github.com/Sirupsen/logrus@v0.11.5: parsing go.mod:
module declares its path as: github.com/sirupsen/logrus
but was required as: github.com/Sirupsen/logrus
make: *** [Makefile:24: validate-deps] Error 1

I think you should update helplers.go module import to the latest version sirupsen, while not Sirupsen.

  1. When I update like above, I also happen to many vendor dependency update warnings. At this time, I remove the directory vendor and make it passed. So, My question is could we remove the vendor dependency and use go mod style? I could use this way to build when I remove validate-only in the makefile and remove vendor directory.

p.s. If the demo could not build smoothly from the scratch, I could not figure out how do we ensure and convince our customers to use it?

@vongosling vongosling added the bug Categorizes issue or PR as related to a bug. label Oct 14, 2020
@vongosling vongosling changed the title Many problem when build from the scratch Many problems when building from the scratch Oct 14, 2020
@carlosroman
Copy link
Contributor

We are addressing the build issues and hope to soon release something soon. The PR #60 has a lot of work gone into it to make sure the build is more reproducible. We've gone through the Makefile to simplify it and remove steps that were no longer needed.

As for moving to go.mod, at the moment we can't as we have to support go 1.9. In the future we hope to be able to switch to go.mod. The infrastructure agent has already moved to go.mod and kept support for go 1.9 so we have a patter we can use.

@brushknight
Copy link
Contributor

Hello! We migrated to public build last October. This PR #60 was merged. Now we release from GH, so I guess all issues with building from scratch should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants