Merge pull request #1642 from dennisschagt/bugfix/issue-1463

Don't redraw screen when returning from temporary EmptyFormAction
newsboat · May 18, 2021 · d2c1914 · d2c1914
2 parents 729edb6 + 86f8b50
commit d2c1914
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/view.cpp b/src/view.cpp
@@ -970,11 +970,15 @@ void View::pop_current_formaction()
 			}
 			i++;
 		}
-		std::shared_ptr<FormAction> f = get_current_formaction();
-		if (f) {
-			f->set_redraw(true);
-			f->set_value("msg", "");
-			f->recalculate_widget_dimensions();
+
+		// Skip cleanup steps when returning from a transient EmptyFormAction
+		if (std::dynamic_pointer_cast<EmptyFormAction>(f) == nullptr) {
+			std::shared_ptr<FormAction> fa = get_current_formaction();
+			if (fa) {
+				fa->set_redraw(true);
+				fa->set_value("msg", "");
+				fa->recalculate_widget_dimensions();
+			}
 		}
 	}
 }