Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not double-count unread items #1140

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

Minoru
Copy link
Member

@Minoru Minoru commented Aug 12, 2020

This PR supersedes #1121.

This affects:

  • -x print-unread CLI option
  • notifications that are displayed after reloads (configured via notify-* settings)

Fixes #444.
Fixes #1120.

Reviews are welcome! If no issues are raised, I'll merge this on Saturday.

This affects:

- `-x print-unread` CLI option
- notifications that are displayed after reloads (configured via
  `notify-*` settings)

Fixes #444.
Fixes #1120.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 57.25% when pulling 366aabe on bugfix/1120-incorrect-unread-count-take-2 into 49794d0 on master.

@polyzen
Copy link

polyzen commented Aug 13, 2020

Confirming that the the unread article count in notifications is correct with this patch as well.

@Minoru Minoru merged commit edadf8f into master Aug 15, 2020
@Minoru Minoru deleted the bugfix/1120-incorrect-unread-count-take-2 branch August 15, 2020 12:05
@Minoru Minoru added this to the 2.21 milestone Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants