Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --cleanup option #1250

Merged
merged 7 commits into from
Oct 31, 2020
Merged

Add a --cleanup option #1250

merged 7 commits into from
Oct 31, 2020

Conversation

dennisschagt
Copy link
Member

Resolves #1182.

@dennisschagt
Add an always_clean option to cleanup_cache()
4d56694 
This `always_clean` option can be used to cleanup the cache once without
having to enable/disable the `cleanup-on-quit` option.
@dennisschagt
Simplify handling of --vacuum in Controller
16a479b
@dennisschagt
Add a --cleanup option which cleans the cache; then exits newsboat
a71e7b6 
It has the same effect as configuring `cleanup-on-quit yes` and
starting+quiting newsboat.
@dennisschagt
delete-read-articles-on-quit only works with --cleanup/cleanup-on-quit
38ba619
@coveralls
Copy link

coveralls commented Oct 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 57.038% when pulling e6f0d0e on dennisschagt:feature/issue-1182 into 1ff8116 on newsboat:master.

Minoru
Minoru requested changes Oct 30, 2020
View reviewed changes
Copy link
Member

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! I have a few comments about the docs though. I'm not sure how to best address them, so please propose your alternatives if you can think of any.

And thanks for working on this! I'm happy to see that you're keeping the momentum ^_^

doc/chapter-firststeps.asciidoc Show resolved Hide resolved
doc/configcommands.dsv Outdated Show resolved Hide resolved
doc/manpage-newsboat.asciidoc Outdated Show resolved Hide resolved
Minoru
Minoru approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you very much @dennisschagt!

@dennisschagt dennisschagt merged commit b76d82e into newsboat:master Oct 31, 2020
@dennisschagt dennisschagt deleted the feature/issue-1182 branch October 31, 2020 15:26
@Minoru Minoru added this to the 2.22 milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minoru Minoru Minoru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.22
Development

Successfully merging this pull request may close these issues.

Add --cleanup to manually do what cleanup-on-quit setting does
3 participants
@dennisschagt @coveralls @Minoru