mark-feed-read: Only mark visible items as read #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisschagt
commented
Mar 28, 2021
Minoru
added a commit
that referenced
this pull request
Jun 27, 2021
5163927 (PR #1558) changed mark-all-read to mark each item individually. That made mark-all-read aware of the filters, but also made it slower. This was especially noticeable with remote APIs, where mark-read latency is high. We can't speed it up in the general case, but when there is no filter, we can fall back onto the faster mark_all_read() method which marks the entire feed in one go. I tested that this new code is indeed faster and doesn't re-introduce #1364. Reported by Oneiric on IRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1364.