Port utils::is_valid_color to rust
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @pwoolcoc! This must be the first PR ever where I couldn't come up with a nitpick. Congrats on that, I guess :) And it also looks like you're going to be the 100th contributor (by GitHub's count), so congratulations on that as well! Looking forward to more contributions from you! |
40 tasks
Minoru
added a commit
that referenced
this pull request
Nov 18, 2018
1. We don't really need the "lazy" part, since we always need a logger, even if just to check that its loglevel is None. 2. #353 uses once_cell already, so it makes sense to switch to reduce the dependency graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #334