Fix building of docs on FreeBSD #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These sed commands fail on FreeBSD as they're interpreted as extended regular expressions. At least, that's what the error message suggests to me. As it turns out using the -e option was wrong in the first place as I thought this switch enables extended regex, which it doesn't. Correct is either -r (GNU sed) or -E (BSD sed). Both implementations support the other's flag as well, so it shouldn't matter which we actually use. * https://www.freebsd.org/cgi/man.cgi?query=sed&sektion=&n=1 * https://stackoverflow.com/a/3139925 Thanks to imm_ on IRC for reporting this and confirming the fix!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sed commands fail on FreeBSD as they're interpreted as extended
regular expressions. At least, that's what the error message suggests to
me. As it turns out using the -e option was wrong in the first place as
I thought this switch enables extended regex, which it doesn't. Correct
is either -r (GNU sed) or -E (BSD sed). Both implementations support the
other's flag as well, so it shouldn't matter which we actually use.
Thanks to imm_ on IRC for reporting this and confirming the fix!