Feat/fixture generator #1484
Merged
Feat/fixture generator #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathggns
reviewed
Nov 16, 2018
… fixture generator via cypress task plugin
Belema
reviewed
Nov 28, 2018
Belema
reviewed
Nov 28, 2018
Belema
reviewed
Nov 28, 2018
Belema
reviewed
Nov 28, 2018
Belema
reviewed
Nov 28, 2018
kaliabadi
reviewed
Dec 3, 2018
kaliabadi
approved these changes
Dec 3, 2018
|
🥇 |
|
This PR has turned off most of our e2e tests. It should not have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And so begins our journey into creating type-safe fixtures for articles
This PR creates a new package called fixture gen and migrates away from the provider test tool package.
The fixture gen package has a responsibility of providing correct fixtures to any client (such as showcases, cypress)
It uses schema introspection and graphqlgen to create types based on the schema.
This means that whenever the schema is updated the types will break and be very obvious as to why.
As part of this, we have refactored an existing article cypress test.
unfortunately, this has broken the other cypress tests that @nehasri89 created. In the interim, I have switched them off and tools have another ticket in this sprint to pick up the work to refactor.