Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TDP-1579) inline image and interactive anchors #2912

Merged
merged 12 commits into from
Apr 11, 2022

Conversation

flashcheeks
Copy link
Contributor

@flashcheeks flashcheeks commented Apr 11, 2022

The PR adds an extra div wrapper to all inline images and interactives. An id attribute will be added to the wrapper if the article contains an anchor link to the element.

This PR also:

  • handles scrolling to element from inline link
  • added url check and fixed typo in utils function
  • additional tests for utils function

@flashcheeks flashcheeks merged commit 2da77a2 into master Apr 11, 2022
@flashcheeks flashcheeks deleted the feat/tdp-1579_inline-image-and-interactive-anchors branch April 11, 2022 16:10
This was referenced Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant