Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to freenode #92

Comments

@pombredanne
Copy link
Member

@pabs3 reported to me that we still have some outdated freenode references https://github.com/search?q=org%3AnexB+freenode&type=code

We should use only Gitter and liberachat

@RahulSingh212
Copy link

I am new to the open-source environment, and I would like to contribute to this issue if it's still unsolved, and it's my request to help me with the references required for this.

@pabs3
Copy link

pabs3 commented Dec 7, 2021 via email

@DebDx
Copy link

DebDx commented Jan 17, 2022

Hi, I am looking forward to work on this issue. Is it still open and unresolved?

@pabs3
Copy link

pabs3 commented Jan 19, 2022

@DebDx thanks for your interest! As you can see from the search link above, the issue is still unsolved.

@purna135
Copy link

Hi @pombredanne, I am working on this.

@pombredanne
Copy link
Member Author

@purnachandramansingh all merged now.. I think this is done!
Thank you ++ for carrying this through!

@purna135
Copy link

purna135 commented Jan 29, 2022

Thank you so much @pombredanne for this opportunity : )
Finally, I had completed my first step 😇

could you please verify once, the search result which are showing now needs any modification on not
https://github.com/search?p=2&q=org%3AnexB+freenode&type=Code

and do have any new tasks for me? I am happy to perform😊
I will be happier if you can give some feedback/improvement for my future contribution.

@pabs3
Copy link

pabs3 commented Jan 30, 2022 via email

@purna135
Copy link

Thank you, @pabs3. I replace the Freenode in https://github.com/nexB/aboutcode/blob/master/docs/source/gsoc/gsoc_2017.rst#L41

Since other files are not doc files, I am waiting for @pombredanne input to modify them.
Do you have any suggestions/guidance on how to modify them?

Thanks

@pombredanne pombredanne reopened this Jan 30, 2022
@purna135
Copy link

Hi @pombredanne, kindly let me know if I can modify the above files or not

@pombredanne
Copy link
Member Author

of course :)

@purna135
Copy link

Hi @pombredanne, I have a doubt here, I just changed

notifications:
  irc:
    channels:
      - "chat.freenode.net#aboutcode"

to

notifications:
  irc:
    channels:
      - "web.libera.chat#aboutcode"

Is this correct?
Should I also add the Gitter URL?

@purna135
Copy link

@purna135
Copy link

https://github.com/nexB/scancode-toolkit-contrib/blob/master/etc/scripts/irc-notify.py#L132
irc_sock.connect((socket.gethostbyname('chat.freenode.net'), 6697))

is this port number(6697) remain same ? like

irc_sock.connect((socket.gethostbyname('web.libera.chat'), 6697))

@pabs3
Copy link

pabs3 commented Jan 31, 2022 via email

@purna135
Copy link

Thanks, @pabs3 @pombredanne, I also deleted the below file and used irc.libera.chat
https://github.com/nexB/scancode-toolkit-contrib/blob/master/etc/scripts/irc-notify.py#L132
but now I am getting the below error, could you please guide how to proceed

yield 'ERROR: ' + error
E           TypeError: cannot concatenate 'str' and 'type' objects

@pabs3
Copy link

pabs3 commented Feb 1, 2022 via email

@purna135
Copy link

purna135 commented Feb 1, 2022

Actually, I made a PR aboutcode-org/scancode-toolkit-contrib#6 after the necessary changes but it's falling some test

image

image

@purna135
Copy link

Hello, @pombredanne. I see two PRs for this issue are still open.

  1. Replace freenode references with libera chat tracecode-toolkit#7
  2. Replace freenode references with libera chat #94

Are they relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment