Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the assignment of Keywords in DejaCode more flexible #48

Closed
DennisClark opened this issue Feb 12, 2024 · 2 comments
Closed

Make the assignment of Keywords in DejaCode more flexible #48

DennisClark opened this issue Feb 12, 2024 · 2 comments
Assignees
@tdruez @DennisClark
Labels
enhancement New feature or request integration Integration with other applications
Milestone
DejaCode 5.1

Comments

@DennisClark
Copy link
Member

We should use the ComponentKeyword as suggestions in the keyword autocomplete fields and remove the validation to allow any keywords values.

In DejaCode, at the moment, only keywords existing as ComponentKeyword in the Dataspace are allowed. This approach is not compatible with automatically adding arbitrary keywords from Scan results or other integration processes.

Background: Scan results from SCTK returns keywords such as:

wrapper
proxy
decorator
Development Status :: 5 - Production/Stable
Programming Language :: Python :: 2
Programming Language :: Python :: 2.7
Programming Language :: Python :: 3
Programming Language :: Python :: 3.5
Programming Language :: Python :: 3.6
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: Implementation :: CPython
Programming Language :: Python :: Implementation :: PyPy
@DennisClark DennisClark added enhancement New feature or request integration Integration with other applications labels Feb 12, 2024
@DennisClark DennisClark added this to the DejaCode 5.1 milestone Feb 12, 2024
@DennisClark DennisClark reopened this Feb 12, 2024
tdruez added a commit that referenced this issue Feb 19, 2024
@tdruez
Add KeywordViewSet to the API #48
93604ec 
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Feb 19, 2024
@tdruez
Refactor the implementation of Keywords on forms #48
fdfc34d 
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 13, 2024
@tdruez
Fix failing unit tests #48
bb21103 
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 13, 2024
@tdruez
Add changelog entry and improve keywords help text in imports #48
8201441 
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 13, 2024
@tdruez
Fix code format #48
31587b7 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented May 13, 2024

@DennisClark Keywords validation was relaxed to accept any values. The existing values in the database are use for the autocompelte suggestion.

@DennisClark
Copy link
Member Author

DennisClark commented May 13, 2024 •
edited
Loading

@tdruez wonderful, thanks. Confirmed in Staging Starship.

tdruez added a commit that referenced this issue May 14, 2024
@tdruez
Refactor the implementation of Keywords on forms #48 (#54)
8827373 
* Add KeywordViewSet to the API #48

Signed-off-by: tdruez <tdruez@nexb.com>

* Refactor the implementation of Keywords on forms #48

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez tdruez closed this as completed May 14, 2024
@tdruez tdruez mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdruez tdruez

@DennisClark DennisClark

Labels
enhancement New feature or request integration Integration with other applications
Projects
None yet
Milestone
DejaCode 5.1
Development

No branches or pull requests
2 participants
@tdruez @DennisClark