Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'status' field to Delta object #117

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Adds 'status' field to Delta object #117

merged 1 commit into from
Apr 3, 2019

Conversation

arnav-mandal1234
Copy link
Collaborator

@arnav-mandal1234 arnav-mandal1234 commented Apr 1, 2019

This adds a new status field in Delta class
Fixes : #110
Signed-off-by: Arnav Mandal arnav.mandal1234@gmail.com

@arnav-mandal1234
Copy link
Collaborator Author

@MaJuRG @pombredanne Kindly review this.
This is my first PR here. :)

Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right direction. See specific comments for needed changes.

src/deltacode/__init__.py Outdated Show resolved Hide resolved
src/deltacode/__init__.py Outdated Show resolved Hide resolved
src/deltacode/__init__.py Outdated Show resolved Hide resolved
src/deltacode/__init__.py Outdated Show resolved Hide resolved
This adds a new status field in Delta class
Fixes - #110
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
@steven-esser
Copy link
Contributor

@arnav-mandal1234 Yeah it looks like MacOS builds are hanging for scancodle-toolkit as well.

I will look into this.

@steven-esser steven-esser merged commit 69a607c into aboutcode-org:develop Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants