Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Divide Cases Functions and Test Files (InterestingScan Results) #6

Merged

Conversation

AyanSinhaMahapatra
Copy link
Collaborator

Add functions to divide cases by location groups, remove non-unique cases,
divide into cases and related analysis, and functions to craft rules from
a group of matches having matched_text fragments.

Adds test scan files for testing. Add data loading functions, and minor
modifications in results_analyze.

Add functions to divide cases by location groups, remove non-unique cases,
divide into cases and related analysis, and functions to craft rules from
a group of matches having matched_text fragments.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Adds test scan files for testing. Add data loading functions, and minor
modifications in results_analyze.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Adds functions to Load License and Rule Information to Construct
Compression related Dictionaries, and reformat File I/O for DataFrames
and other files to avoid circular Imports.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Collaborator Author

@MaJuRG @pombredanne I added the Adds rules-license-analyze functions commit here from #5, because tests won't work unless all the functions are there. That was already approved @MaJuRG

Also, the main functions are there in divide_cases.py which I request review for and there's a lot of Scan Files I don't think those need review.

@@ -371,9 +347,9 @@ def create_package_level_dataframe(self, json_filename=None):
files_dataframe, metadata_dataframe = self.modify_package_level_dataframe(path_json_dataframe)

# Append metadata level information to a MetaData File
self.append_metadata_dataframe(metadata_dataframe)
# self.append_metadata_dataframe(metadata_dataframe)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to keep these around?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No oops, that's a mistake I'll remove that.

@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Add Divide Cases Functions and Tests Add Divide Cases Functions and Test Files (InterestingScan Results) Oct 20, 2020
Copy link
Contributor

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pombredanne pombredanne merged commit 76d8512 into aboutcode-org:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants