Prefix non SPDX licenses "LicenseRef-scancode-" #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScanCode can detetect many more licenses than those listed in the SPDX standard. Such licenses are considered external and are named LicenseRef-xxx. This change adds a 'LicenseRef-scancode-' prefix to such licenses to clarify that the license refers to the license as defined by ScanCode and avoid name collisions with output from other license scanners. Signed-off-by: Tobias Furuholm <tobiasfuruholm@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #1307 +/- ##
===========================================
+ Coverage 84.11% 84.13% +0.02%
===========================================
Files 117 117
Lines 13119 13119
===========================================
+ Hits 11035 11038 +3
+ Misses 2084 2081 -3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #1307 +/- ##
===========================================
+ Coverage 84.11% 84.13% +0.02%
===========================================
Files 117 117
Lines 13119 13119
===========================================
+ Hits 11035 11038 +3
+ Misses 2084 2081 -3
Continue to review full report at Codecov.
|
|
@furuholm thank you! Looking good and merging, |
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 12, 2019
Like ScanCode itself does for SPDX file output as of aboutcode-org/scancode-toolkit#1307 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 12, 2019
Like ScanCode itself does for SPDX output file formats as of aboutcode-org/scancode-toolkit#1307 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 12, 2019
Like ScanCode itself does for SPDX output file formats as of aboutcode-org/scancode-toolkit#1307 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 12, 2019
Like ScanCode itself does for SPDX output file formats as of aboutcode-org/scancode-toolkit#1307 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 12, 2019
Like ScanCode itself does for SPDX output file formats as of aboutcode-org/scancode-toolkit#1307 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 12, 2019
Like ScanCode itself does for SPDX output file formats as of aboutcode-org/scancode-toolkit#1307 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #532
ScanCode can detetect many more licenses than those listed in the
SPDX standard. Such licenses are considered external and are
named LicenseRef-xxx. This change adds a 'LicenseRef-scancode-'
prefix to such licenses to clarify that the license refers to the
license as defined by ScanCode and avoid name collisions with
output from other license scanners.
Signed-off-by: Tobias Furuholm tobiasfuruholm@gmail.com