Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PackageManifest Class #2748

Merged
merged 27 commits into from
Jan 3, 2022
Merged

Add PackageManifest Class #2748

merged 27 commits into from
Jan 3, 2022

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Nov 3, 2021 •
edited
Loading

Fixes #2747

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@AyanSinhaMahapatra
Rename package attribute metafiles to file_patterns
d5b09c3 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add PackageManifest class to models
1a4bd31 
Adds a mixin class PackageManifest to models which will have the base
implementations of Package Manifest specific methods for recognizing and
creating ecosystem specific package manifest objects, which will inherit
from this class and the ecosystem Package class.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Modify package classes to inherit PackageManifest mixin
faa5f3a 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Modify test expectations for recognize_package_manifests
a2dddba 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest classes for cocoapods
1d561d5 
Creates PackageManifest classes for all individual types of cocoapods manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest class fot aboutfiles
9466e0f 
Creates PackacgeManifest class for aboutfiles and overrides
detection and PackageMamanifest creation methods.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the 2098-top-level-packages branch 3 times, most recently from 28846b8 to 23112ed Compare November 3, 2021 12:06
@AyanSinhaMahapatra
Create PackageManifest classes for NPM
ab20f29 
Creates PackageManifest classes for NPM manifests
and overrides detection and PackageMamanifest creation methods.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest classes for phpcomposer
a0d0010 
Creates PackageManifest classes for all phpcomposer manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the 2098-top-level-packages branch 2 times, most recently from 2ab8558 to 9b7f70b Compare November 4, 2021 09:01
@AyanSinhaMahapatra
Create PackageManifest class for Haxe
9e5d3b7 
Creates PackageManifest classes for haxelib json manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest classes for cargo
45553ae 
Creates PackageManifest classes for rust cargo manifests`
and overrides the methods for detection and PackageManifest creation

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add PackageManifest class for opam
b72c03e 
Creates PackageManifest classes for opam manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add PackageManifest class for bower
83dee55 
Creates PackageManifest class for bower json manifest
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest class for freebsd
e519e8e 
Creates PackageManifest class for freebsd compact manifest
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add PackageManifest classes for ruby manifests
6270119 
Creates PackageManifest class for various ruby manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add PackageManifest classes for pypi manifests
fd6d746 
Creates PackageManifest class for various python manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest classes for golang manifests
a368135 
Creates PackageManifest class for go.mod and go.sum manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest class for nuspec manifest
2dbe916 
Creates PackageManifest class for nuspec manifest
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add PackageManifest classes for chef manifests
f525e59 
Creates PackageManifest classes for chef manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest classes for conda
54e3d20 
Creates PackageManifest classes for conda manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest class for readme manifests
a866432 
Creates PackageManifest class for readme manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest classes for pubspec
1277580 
Creates PackageManifest classes for pubspec manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest classes for windows manifests
8a30df3 
Creates PackageManifest classes for various windows manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Modify PackageManifest classes in build
b014cd9 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Create PackageManifest class for rpm
b8968e2 
Creates PackageManifest class for rpm manifests
and overrides the methods for detection and PackageManifest creation.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@pombredanne pombredanne mentioned this pull request Nov 26, 2021
Merged
4 tasks
@AyanSinhaMahapatra
Modify PackageManifest class names and attributes
d2b37a1 
Modifies PackageManifest class names to be camelcase and deletes
attribute `manifest_type` from individual classes.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Remove duplicate models and update docstrings
b5196ff 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne This is all green and ready to review!

@AyanSinhaMahapatra
Remove recognize function from package class
7b5cf8c 
Removes recognize function from Package Class, since
the recognize function is now at PackageManifest class
and this isn't used anywhere.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
pombredanne approved these changes Dec 28, 2021
View reviewed changes
src/packagedcode/__init__.py Show resolved Hide resolved
pombredanne
pombredanne approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging at last! Thank you ++

@pombredanne pombredanne merged commit 9ed2cb4 into develop Jan 3, 2022
@pombredanne pombredanne deleted the 2098-top-level-packages branch January 3, 2022 16:33
AyanSinhaMahapatra added a commit that referenced this pull request Feb 1, 2022
@AyanSinhaMahapatra
Adds PackageManifest classes for cran
9f9e3a6 
Creates PackageManifest classes for cran description manifests
and overrides the methods for detection and PackageManifest creation.

See #2748

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra added a commit that referenced this pull request Feb 1, 2022
@AyanSinhaMahapatra
Adds PackageManifest class for maven
695ae3b 
Creates PackageManifest class for maven pom.xml  manifests
and overrides the methods for detection and PackageManifest creation.

See #2748

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Feb 7, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@JonoYang JonoYang Awaiting requested review from JonoYang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package model updates: Add new PackageManifest class
2 participants
@AyanSinhaMahapatra @pombredanne