Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistency in --html-app FILE in cli-reference #2790

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

maynaS
Copy link
Contributor

@maynaS maynaS commented Jan 7, 2022

Fixes #2789

Before

scancode -clpieu --csv output.html samples

After

scancode -clpieu --html-app output.html samples

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
    It is a small documentation change, therefore I pushed it to the develop branch itself.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maynaS Thank you ++
You need to format you signoff, it must be on the last line of your commit message.
Also do you mind to squash all in a single clean commit with a single clean message?

@pombredanne
Copy link
Member

Thanks! Do you mind to squash your commits in a single one with
A subject that's less than 50 characters
A signoff on the last line of the message

Signed-off-by: maynaS <samjshah2002@gmail.com>
@maynaS
Copy link
Contributor Author

maynaS commented Jan 15, 2022

@pombredanne Hey, can you check it out? I have done what you asked for

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++
LGTM, merging!

@pombredanne pombredanne merged commit 0b57869 into aboutcode-org:develop Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in documentation of --html-app FILE in Command Line Interface Reference
2 participants