Issue 26 : fixed slow extraction #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated file_walk to use this code. * added ignore support to file_walk
* moved basic kinds * excluded patches and included package in default
* this avoids aggressive extraction of patches, which is a more advanced type of extraction
* this was due to a pattern with []
* simplified copytree * changed chmod to not recurse by default and use explicit recurse * added debug logginf
* now using the dotodot resolution in tar and elsewhere
* an extension alone is not enough to define an archive * score can now be negative
* as reported in aboutcode-org#26 * address slowness issue that was due to multiple re-extraction and to superfluous recursive chmod * simplified code to return ExtractEvent and no longer use a job/queue logic
* tar.py will eventually go away, but for now to ease the transition to using libarchive for tars, existing tar tests have been duplicated to test tar.py in isolation
* Also replaced tar with libarchive2. * Cleaned debug logging. * Ensured warning messages are simpler and that Exception are raised on errors (some were only warnings)
pombredanne
added a commit
that referenced
this pull request
Jul 13, 2015
Issue 26 : fixed slow extraction
This was referenced Jul 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #26 (and #27 as a side effect). This consist of a rather significant refactoring of the extract code as well as simplification, improved tracing and new tests. This also ditched the tar.py implementation in favour of libarchive2 for tarball extraction