Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report extracted_requirement correctly #2984

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Report extracted_requirement correctly #2984

merged 1 commit into from
Jun 12, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jun 7, 2022 •
edited
Loading

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

Fixes #2983

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@AyanSinhaMahapatra
Copy link
Member

AyanSinhaMahapatra commented Jun 7, 2022 •
edited
Loading

LGTM! Thanks.

@TG1999
fix get_requires_dependencies
19aed1c 
Reference: aboutcode-org#2983
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 changed the title Reference: https://github.com/nexB/scancode-toolkit/issues/2983 fix get_requires_dependencies Jun 7, 2022
@pombredanne pombredanne changed the title fix get_requires_dependencies Report extracted_requirement correctly Jun 7, 2022
pombredanne
pombredanne approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pombredanne
Copy link
Member

These test is failing likely from the updated results:
tests/packagedcode/test_pypi.py::TestPyPiEndtoEnd::test_package_scan_pypi_end_to_end

@pombredanne
Copy link
Member

tests/packagedcode/test_pypi.py::TestPyPiEndtoEnd::test_package_scan_pypi_end_to_end is failing only in the CI. Merging anyway.

@pombredanne pombredanne merged commit 9d885d5 into aboutcode-org:develop Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_requires_dependencies gives out specifier in extracted_requirement
3 participants
@TG1999 @AyanSinhaMahapatra @pombredanne