Fix issues in PythonInstalledWheelMetadataFile.assign_package_to_resources()
#3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correctly assign path_ref when partitioning path_ref in PythonInstalledWheelMetadataFile.assign_package_to_resources Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
fix-PythonInstalledWheelMetadataFile-assign_package_to_resources
branch
3 times, most recently
from
877bf58
to
3d2b6a1
Compare
* Add test for extracted pypi wheel
* Update test expectations
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
fix-PythonInstalledWheelMetadataFile-assign_package_to_resources
branch
from
3d2b6a1
to
1abd495
Compare
pombredanne
approved these changes
Aug 24, 2022
pombredanne
deleted the
fix-PythonInstalledWheelMetadataFile-assign_package_to_resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues in
PythonInstalledWheelMetadataFile.assign_package_to_resources():PythonInstalledWheelMetadataFile.assign_package_to_resources()would not correctly find thesite-packagesdirectory, as it called.parent()too many times on the datafile Resource.path_refwas not being assigned correctly andPythonInstalledWheelMetadataFile.assign_package_to_resources()would fail during Package assembly.