Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct purl type for cocoapods #3081 #3096

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Correct purl type for cocoapods #3081 #3096

merged 1 commit into from
Sep 12, 2022

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Sep 7, 2022 •
edited
Loading

  • Modify purl type for cocoapods packages and deps from pods to the correct type cocoapods.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

pombredanne
pombredanne requested changes Sep 12, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Do you mind to add a changelog entry too?

@AyanSinhaMahapatra
Correct purl type for cocoapods #3081
bf78589 
* Modify purl type for cocoapods packages and deps from `pods`
  to the correct type `cocoapods`.

Reference: #3081
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne added the changelog entry, thanks!

pombredanne
pombredanne approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All clear. Please merge

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 6007301 into develop Sep 12, 2022
@pombredanne pombredanne deleted the 3081-correct-type-cocoapods branch September 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne