Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required phrase to JSR rule #3218

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add required phrase to JSR rule #3218

merged 1 commit into from
Jan 30, 2023

Conversation

bennati
Copy link
Contributor

@bennati bennati commented Jan 23, 2023

Avoids ambiguity with other rules

Signed-off-by: Bennati, Stefano stefano.bennati@here.com

@bennati
Add required phrase to JSR rule
575aa6a 
Signed-off-by: Bennati, Stefano <stefano.bennati@here.com>
pombredanne
pombredanne approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pombredanne pombredanne merged commit 6358a4b into aboutcode-org:develop Jan 30, 2023
@bennati bennati deleted the fix-jsr-rule branch January 31, 2023 10:31
@zhernovs
Copy link

zhernovs commented Apr 5, 2023 •
edited
Loading

Hi @pombredanne
Is there any chance to include this into some 31.* patch?
We would love to use newer version of scancode (currently on 30.1.0) together with ORT. But ORT still doesn't support new output format version that you have in 32.* On the other hand we can't use 31.* without a fix from this commit. Perhaps another patch version (31.2.5) won't hurt.

@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bennati @zhernovs @pombredanne