Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build app archives for all python versions #3232

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 27, 2023

Fixes #3124
Fixes #3215
Fixes #3235

  • Builds app archives for python 3.7-3.11 for linux/mac/windows
  • Modifies app archive creation script to pass python version as variable
  • Publishes python 3.11 wheel
  • smoke test install and scan for all python versions in linux/mac/windows
  • Update utils_thirdparty.py with python 3.11 support
  • updates https://github.com/nexB/thirdparty-packages with new lxml/MarkupSafe wheels having py311 support

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@AyanSinhaMahapatra AyanSinhaMahapatra added this to the v32.0 milestone Jan 27, 2023
* Builds app archives for python 3.7-3.11 for linux/mac/windows
* Modifies app archive creation script to pass python version as variable
* Publishes python 3.11 wheel
* smoke test install and scan for all python versions in linux/mac/windows

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member Author

AyanSinhaMahapatra commented Jan 30, 2023

See https://github.com/AyanSinhaMahapatra/scancode-toolkit/actions/runs/4047350268 for a successful GitHub action running on my fork, all artifacts generated successfully there, fails on pypi release obviously as it doesn't have auth.

See created github release with all the app archives, wheels and sdist https://github.com/AyanSinhaMahapatra/scancode-toolkit/releases/

@pombredanne this is ready for your review.

Copy link
Member Author

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne for your review.

.github/workflows/scancode-release.yml Outdated Show resolved Hide resolved
.github/workflows/scancode-release.yml Show resolved Hide resolved
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Thanks!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 5ec85c4 into develop Feb 17, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the app-archives-all-python branch February 17, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants