Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3250: Invalid SPDX with empty file: no SHA1 #3279

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix #3250: Invalid SPDX with empty file: no SHA1 #3279

merged 2 commits into from
Mar 28, 2023

Conversation

vargenau
Copy link
Contributor

Fixes #3250

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: Marc-Etienne Vargenau marc-etienne.vargenau@nokia.com

@vargenau
Fix aboutcode-org#3250: Invalid SPDX with empty file: no SHA1
e0af1d3 
Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
@vargenau vargenau mentioned this pull request Feb 27, 2023
Closed
pombredanne
pombredanne requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! let's add a test to avoid any regression.

@vargenau
Add test test_output_spdx_tv_sh1_of_empty_file
d7e8318 
Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
@vargenau
Copy link
Contributor Author

vargenau commented Mar 2, 2023

I have added a test that is successful is tests/formattedcode/test_output_spdx.py

However, some tests fails that seem unrelated. Can you please check?

AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vargenau LGTM! Thanks!

The test failures seem to be a heisenbug and happens in other PRs too sometimes, nothing related to this change ofc.

pombredanne
pombredanne approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AyanSinhaMahapatra
Copy link
Member

@vargenau Thanks, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 80ecd35 into aboutcode-org:develop Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid SPDX with empty file: no SHA1
3 participants
@vargenau @AyanSinhaMahapatra @pombredanne