Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit check_rdf_scan so that SPDX rdf tests don't automatically pass #3448 #3451

Merged

Conversation

armintaenzertng
Copy link
Contributor

@armintaenzertng armintaenzertng commented Jul 12, 2023

Also adapted the expected.rdf files from tests that failed thereafter.

Fixes #3448

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See comments below

tests/formattedcode/test_output_spdx.py Show resolved Hide resolved
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks++

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 200fb10 into aboutcode-org:develop Jul 17, 2023
@armintaenzertng armintaenzertng deleted the fix_rdf_tests branch July 17, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPDX rdf tests pass automatically
2 participants