Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purldb_scan_queue_worker unit test are dependeing on network availability #1206

Closed
tdruez opened this issue May 6, 2024 · 0 comments
Closed

purldb_scan_queue_worker unit test are dependeing on network availability #1206

tdruez opened this issue May 6, 2024 · 0 comments

Comments

@tdruez
Copy link
Contributor

tdruez commented May 6, 2024 •
edited
Loading

Unit tests should never depend on having internet connectivity to pass.
The download behavior here should be mocked.

test_scanpipe_management_command_purldb_scan_queue_worker
test_scanpipe_management_command_purldb_scan_queue_worker_failure
test_scanpipe_management_command_purldb_scan_queue_worker_continue_after_fail
JonoYang added a commit that referenced this issue May 6, 2024
@JonoYang
Mock download get requests #1206
b3fe59f 
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue May 7, 2024
@JonoYang
Mock download get requests #1206
15a34b2 
Signed-off-by: Jono Yang <jyang@nexb.com>
tdruez pushed a commit that referenced this issue May 7, 2024
@JonoYang
Mock download get requests #1206 (#1209)
d6e7bf0 
Signed-off-by: Jono Yang <jyang@nexb.com>
@tdruez tdruez closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdruez