Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the entire content of map files #1014

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

keshav-space
Copy link
Member

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Copy link
Contributor

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit hackich, shouldn't we use a better global way to display source with the best integrity possible?

What's your take @keshav-space ?

@keshav-space
Copy link
Member Author

This seems a bit hackich, shouldn't we use a better global way to display source with the best integrity possible?

@tdruez We are using textcode as a global way for displaying source, and it's working well, except for the map files.
I don't believe handling this use case in Textcode is what we want, as the current behavior of textcode is desirable in the SCTK use case. Additionally, the idea of returning numbered_text_lines won't make much sense for the entire map file, given that there are nested files that will have their own numbered lines.

scanpipe/models.py Outdated Show resolved Hide resolved
scanpipe/tests/test_models.py Outdated Show resolved Hide resolved
@tdruez tdruez merged commit 62871ae into main Jan 22, 2024
7 checks passed
@tdruez tdruez deleted the 1013-properly-display-map-files branch January 22, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCIO not displaying the entire content of map files
2 participants